Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gauge/goal: Tooltip always includes "_all" #101064

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Gauge/goal: Tooltip always includes "_all" #101064

merged 2 commits into from
Jun 3, 2021

Conversation

VladLasitsa
Copy link
Contributor

Closes: #93030

Summary

Removes from tootlip row 'All docs: _all' for goal and gauge visualizations.

@VladLasitsa VladLasitsa requested a review from alexwizp June 1, 2021 15:45
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 569.1KB 569.2KB +74.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 390 346 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp
alexwizp approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@VladLasitsa VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0 labels Jun 2, 2021
@VladLasitsa VladLasitsa marked this pull request as ready for review June 2, 2021 13:42
@VladLasitsa VladLasitsa requested a review from a team June 2, 2021 13:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine @VladLasitsa 👏
Thank you for also adding a test 😉

@VladLasitsa VladLasitsa merged commit 6f106e4 into elastic:master Jun 3, 2021
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Jun 3, 2021
@VladLasitsa
Gauge/goal: Tooltip always includes "_all" (elastic#101064)
3d351de 
* Don't show _all for goal and gauge in tooltip

* add unit test
@VladLasitsa VladLasitsa mentioned this pull request Jun 3, 2021
Merged
VladLasitsa added a commit that referenced this pull request Jun 3, 2021
@VladLasitsa
Gauge/goal: Tooltip always includes "_all" (#101064) (#101248)
70bd851 
* Don't show _all for goal and gauge in tooltip

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gauge/goal: Tooltip always includes "_all"
5 participants
@VladLasitsa @kibanamachine @elasticmachine @stratoula @alexwizp